[MERGE][REGRESSION][1.6] fetching knits => packs

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> bb:approve
> 
> 
>>> Specifically, the bug starts with a knit repository that is 70MB on disk (35MB
>>> --apparent). And it ends up 170MB after copying into a pack repository.
>>> Further, it uses 700+MB of memory for the copy.
>> So, this was introduced by Robert's change:
>>  3584 Canonical.com Patch Queue Manager	2008-07-29 [merge]
>>       (robertc) Give repository objects more control over the generic fetch
>>       	process. (Robert Collins)
>>
>> We haven't noticed the problem in general fetching, because it is rare that
>> you fetch a lot of texts and when you already have the left-hand parent in
>> your repository, it just re-does the delta.
> 
> Thanks for catching this. *blush*.
> 
> To test it we'd want to instrument a repositories vf objects to catch
> method calls and then do a fetch where we try both values of
> fetch_uses_deltas, and ensure its passed through correctly.
> 
> -Rob

Attached is a patch which includes tests for all 4 VF objects. I have to cheat
a bit for the signatures one, because it does extra get_record_stream calls.
That should be fixed eventually, but it doesn't need to happen now.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIqfmGJdeBCYSNAAMRAkKQAJ0Qafs3iF8tSDDZrkgqOpguKmls/QCgurFt
jcmY3v8YCwYvVjcrHslHcAc=
=gxHH
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fetch_regression_256767.patch
Type: text/x-diff
Size: 21165 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080818/e16e18fd/attachment-0001.bin