RFC: dirstate & locks

[Robert Collins]

On Fri, 2008-08-15 at 18:34 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > On Fri, 2008-08-15 at 08:25 -0500, John Arbash Meinel wrote:
> >>> I don't like this because it doesn't map well to what users want to
> >> do -
> >>> and all commands that need iter_changes to work would have to be
> >>> modified to do this - ls, diff, status are only the obvious ones.
> >>>
> >>>
> >>> -Rob
> >> Um... they already do this, well diff and status do. It is part of the
> >> unlock function already, IIRC.
> > 
> > by 'this' I meant 'take out a write lock'
> > 
> > -Rob
> 
> I'm saying that diff and status already take out a dirstate-write-lock,
> which is not very far removed from taking out a WT-level write lock.

I consider that a bug though, and escalating it to a WT level write lock
means better tree implementations cannot behave better, so we shouldn't
do that.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080816/8a1f7a6f/attachment-0001.pgp