[MERGE] Add osutils.pump_string_file helper function.

John Arbash Meinel john at arbash-meinel.com
Fri Aug 15 14:24:59 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> An updated patch for bug 255656..
> 
> -Rob
> 
BB:approve

I also like that in order to make it testable, you made the segment_size
configurable. The only test I would personally add would be a call that
uses a non-empty string and does not set the segment_size. Just to make
sure that there is a valid fallback segment_size, or maybe that passes
None explicitly?

Anyway, good enough either way.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkilg6sACgkQJdeBCYSNAAOZdQCgy0FwWDPbQY/wcLjiQHwoPCLb
CYMAn3MfwCUp/XkZxn8FpawYQRKVNdZR
=Q0/8
-----END PGP SIGNATURE-----



More information about the bazaar mailing list