[MERGE] Move the notes on writing tests out of HACKING into a new file, and improve them.

Robert Collins robertc at robertcollins.net
Wed Aug 13 06:44:29 BST 2008


On Wed, 2008-08-13 at 14:39 +1000, Andrew Bennetts wrote:

> This text happens to be untouched by my patch, just moved as-is!  So, I think
> forcing people to re-read it is paying off ;)
> 
> I'd be happy to ditch TestPlatformLimit from this file.  The table a bit below
> suggests that the intended distinction is that when running the test suite in
> “strict” mode a test skipped platform limit will pass, but a test skipped due to
> an unavailable feature will fail.  We seem to be doing just fine without having
> implemented this distinction, so we probably shouldn't weigh our docs down with
> it.
> 
> Hmm, I see looking at that table that a couple of places in this file say
> “TestDependencyMissing” (which doesn't exist) when they should say
> “UnavailableFeature” (which does).  I'll fix that.

I think that instructions-on-use should not refer to TODO's :). So yes,
my vote is to remove it. If we want such a distinction, someone can file
a patch which actually adds it.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080813/b440f174/attachment.pgp 


More information about the bazaar mailing list