[REVIEW] Add basic --color support to bzr diff

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Russ Brown wrote:
> I've reached a point where colour output is working, and before I
> continue I'd like some feedback to make sure I am on the right track.

Why have you chosen to reimplement color diff rather than adapting the
code from bzrtools cdiff?

The result is less featureful, since it doesn't allow color
customization, doesn't support style checks, and doesn't auto-detect
color support.

If you're going to replace cdiff, please replace it with something
*better*, not worse.

> I have gone with adding the --color option to diff: I agree with the
> discussion about always/auto/never, but I think that is more applicable
> to the config file side of things than the command line options.

We usually configure commands using aliases, so only existing
commandline options are typically used to configure commands.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIncDU0F+nu1YWqI0RAsF4AJ4s+yYeu4JRbX8VIaazfXlvNLujcgCeMbJ/
+v4IDuoaPAetk8Bc3pjFWcY=
=3u/V
-----END PGP SIGNATURE-----