[MERGE] Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)

[James Westby]

On Mon, 2008-08-04 at 17:33 +1000, Robert Collins wrote:
> This fixes bug 3117, adding a -x option to commit - 
> bzr commit -x foo -x bar 
> now means 'commit everything except for foo and bar'.

Hi Rob,

Thanks for working on this, it looks good for the most part
to me.

I have two comments though.


> --- bzrlib/commit.py    2008-04-24 07:22:53 +0000
> +++ bzrlib/commit.py    2008-08-04 07:29:51 +0000
> @@ -204,7 +204,8 @@
>                 reporter=None,
>                 config=None,
>                 message_callback=None,
> -               recursive='down'):
> +               recursive='down',
> +               exclude=None):

Isn't this an API break for tree.commit() ?

Also, I would like to see a test for your assertion in the help
text, that "commit foo -x foo/bar" commits everything in foo
except foo/bar. I'd perhaps also like to see a test that
"commit foo -x foo" raises PointlessCommit, assuming that is
the intent.

Thanks,

James