RFC: logging refactoring/tweak

Martin Pool mbp at canonical.com
Mon Aug 4 08:14:53 BST 2008


On Mon, Aug 4, 2008 at 4:22 PM, Robert Collins
<robertc at robertcollins.net> wrote:
> On Mon, 2008-08-04 at 12:46 +1000, Martin Pool wrote:
>> On Sun, Aug 3, 2008 at 11:30 AM, Robert Collins
>
>> >
>> > To:
>> >  - push the search evaluation in to the _iter_revisions call
>> >  - use a stack of iterators that can be nested (e.g. to allow
>> >   delta generation to be done after searchRE is evaluated, and to
>> >   allow bzr-search to eliminate parts of view_revisions)
>> >
>> > Thoughts?
>>
>> That sounds good.  Rather than poking this into _iter_revisions maybe
>> we can change this into some kind of composition pipeline, where
>> looking into the full text index is generating the set of revisions to
>> search...
>
> Yes thats what I mean - a stack of iterators is a pipeline :)

I meant that exposing them directly as Python iterators might not be
ideal, if that means the caller dictates which one is driving it and
that they plug together by passing one revision at a time.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list