[MERGE] Move install_revision(s) onto the Repository object.

[Robert Collins]

On Mon, 2008-08-04 at 05:55 +0200, Jelmer Vernooij wrote:
> Am Montag, den 04.08.2008, 13:45 +1000 schrieb Robert Collins:
> > On Mon, 2008-08-04 at 05:26 +0200, Jelmer Vernooij wrote:
> > > The attached patch refactors the install_revision and
> > > install_revisions functions to be methods on Repository, so it's
> > > possible for Repository implementations (such as bzr-svn) to override
> > > it.
> > 
> > bb:resubmit
> > 
> > Where it is has been tested; moving it onto a class that repositories
> > are (expected) to sometimes override means that it becomes part of the
> > interface and needs interface level tests.
> > 
> > I think moving it is a good thing to do; but please ensure that all the
> > tests for it are moved/copied/extended to ensure that it has adequate
> > coverage: the tests for it on a bzr-svn repository passing should be
> > enough to be confident it works. (and likewise on packs etc etc).
> There were already tests for it in
> bzrlib/tests/repository_implementations/ - is that the sort of interface
> tests you mean? If not, what sort of interface tests do you mean?

Hmm, I only saw one test updated :) that is where I would expect tests
for it to live though..
--Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080804/e3e449cf/attachment.pgp