[MERGE/RFC] MultiWalker

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> John Arbash Meinel wrote:
>> Now with patch attached.
>>
>> John Arbash Meinel wrote:
>> | To make progress towards updating merge to handle criss-cross a bit
>> | better, I've written a helper class.
> 
> bb:tweak
> 
>> +        :param master_tree: All trees will be 'slaved' to the master_tree. Such
>> +            that nodes in master_tree will be used as 'first-pass' sync points.
> 
> No need for multiple sentences here ...
> 
>   "the master_tree such that ..."
> 
>> +        dirname, basename = os.path.split(path)
> 
> Should you be using osutils.split instead here?
> 
> Ian C.
> 

I can, though it is universally defined as os.path.split. (There is no
branching code, and os.path.split never *introduces* new path separators to
confuse anything.)

I'll switch for consistency if you like.

Thanks,
John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIkw+xJdeBCYSNAAMRAtXaAKC/i/za65jA/ly+DjIOV6d8UPeEMwCfeD6T
0wNxa8J9QkB5dblaTt5CK3g=
=BoWb
-----END PGP SIGNATURE-----