[MERGE] do not export .bzrrules

Ian Clatworthy ian.clatworthy at canonical.com
Wed Jul 30 01:32:30 BST 2008


John Arbash Meinel wrote:
> Ian Clatworthy wrote:
> | Currently, the export command skips over .bzrignore. This
> | simple patch extends that logic so that other "magic"
> | files in the .bzr* namespace - like .bzrrules - are
> | skipped over during export as well.
> |
> | Ian C.
> |
> 
> The only problem I know is that there are plugins which create
> ".bzr-FOO" directories. I would imagine they don't really want them
> exported either. I'm just a bit concerned that they don't have a *say*
> in the matter.

They can always use a slightly different namespace like .FOO-bzr I guess.
Otherwise, there are several ways of solving this and I rather wait until
we get a concrete case before adopting one. I hope its YAGNI.

> As for tests, if we are going to make it "startswith" it would be good
> to test a directory structure, to ensure that:
> 
> .bzr-adir/
> and
> 
> .bzr-adir/afile
> 
> Also are not getting exported. Mostly because not exporting .bzr-adir
> but then exporting .bzr-adir/afile would cause inconsistencies with some
> exporters.

Done.

Thanks for the review,
Ian C.



More information about the bazaar mailing list