bzr serve --http ?

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| On Mon, Jul 28, 2008 at 4:14 PM, Jonathan Lange <jml at mumak.net> wrote:
|> On Mon, Jul 28, 2008 at 12:42 PM, Robert Collins
|> <robertc at robertcollins.net> wrote:
|>> So loggerhead is newer better brighter etc etc.
|>>
|>> I think its nicer than the hg webserve in nearly every regard these
|>> days; except for one rather niggly thing:
|>> '$bzr serve --http'
|>> bzr: ERROR: no such option: --http
|> It'd be great to have such a simple way of launching Loggerhead.
|>
|> I don't think it should be an option to the 'bzr serve' command
|> though. I'd expect the command you suggested to launch a
|> smartserver-enabled HTTP server. Launching Loggerhead should probably
|> get its own command; perhaps 'bzr webserve' or 'bzr webui'?
|
| I don't think you even need an option at all.  It would be quite
| feasible to serve either bzr+tcp or http over the same port as both of
| them (iirc) start with a line that identifies the request.  It would
| not be unprecedented either; my little hp inkjet printer does it.
|
| Or maybe you should have options, defaulting to on, as to whether it
| will serve dumb files, bzr hpss, and a pretty web interface.
|

I think that is a reasonable idea.

One thing I would mention, just for beuno to be aware of....

The default Python HTTP server does not support range requests. Without
range requests bzr performs rather horribly with packs. Because it has
to download the whole pack every time someone requests 20 bytes out of
it. And our code doesn't try to cache things so it ends up making lots
of these full-text requests and then returns a few pages.

I believe Vila implemented range handling so that we could get proper
testing of the functionality. So you might want to dig around a bit for
that. (I believe he is on vacation for the next 3 weeks.)

But range handling would be pretty much critical for any dumb server we
want to bundle into bzr.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiPJFsACgkQJdeBCYSNAANTvgCgo7M+z74p1nWIy2ZwMR9fqVbc
R/QAoJ9NDNX4nPRUMhHLDsVVeisyVD7t
=Zr9f
-----END PGP SIGNATURE-----