[MERGE] Fetch into stacked branches works correctly

Aaron Bentley aaron at aaronbentley.com
Mon Jul 28 07:24:05 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

This patch fixes Bazaar so fetching into a stacked branch works
correctly.  Jonathan Lange discovered this bug.  I helped code up the
fix and test.

The problem is that the Packer approach to fetch has some bad layering.
 It attempts to ensure all the texts that are fetched can be
constructed, but on the pack level, the compression parents are missing.
 So the test fails erroneously.

For fetching *from* stacked branches, we need to work on a higher level,
so we might as well use the same codepath when fetching *to* stacked
branches.

So this patch changes fetch to use the KnitRepoFetcher when the *target*
is stacked, not only when the *source* is stacked.

Like my previous patch in this area, this issue would have been masked
when the stacked_on branch was the source.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIjWYF0F+nu1YWqI0RAqtYAJsH7fQEE1j+tSTCVK/uBqmUs9jeTQCePCs5
Z0b/iRaPbDfMToad5rY75kk=
=V1dg
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fetch-revisions.patch
Type: text/x-diff
Size: 5378 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080728/e9048b2e/attachment.bin 


More information about the bazaar mailing list