[RFC] Splitting bzr-specific functions out of Repository

[Robert Collins]

On Sun, 2008-07-27 at 21:05 +0200, Jelmer Vernooij wrote:
> Would anybody be opposed to splitting the bzr-specific functions out of
> Repository into a BzrRepository class that is a subclass of Repository,
> similar to BzrBranch and Branch?

I find the bzrbranch/branch split to be quite unsatisfactory. It has
lead to some [transient] bugs in fact.

Presumably you're suggesting this to make your life easier :) - what in
particular is causing you friction/headaches? (Just having the methods
there is at most unclear). Is it needing a more clear definition of what
you need to implement, or ???

> The functions I'm thinking of that could be in BzrRepository only are:
> 
> Repository.get_inventory_xml -> BzrRepository.get_inventory_text
> Repository.get_revision_xml -> BzrRepository.get_revision_text
> Repository.get_revision_sha1 -> BzrRepository.get_revision_sha1
> Repository.get_inventory_sha1 -> BzrRepository.get_inventory_sha1
> Repository.serialise_inventory -> BzrRepository.serialise_inventory

These are already largely generic, for a given serialiser [but not as
generic as they need to be - see split inventories for instance, and
obviously bzr-svn and bzr-git are radically different].

If we don't want these on the public interface, I'd rather we do the
deprecation dance and give them _ names.

If instead we do want them public, but they in some manner interfere
with bzr-git and bzr-svn, lets address that directly.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080728/7bb9fdc7/attachment.pgp