[RFC] deprecate InventoryEntry put_on_disk and get_tar_item

Robert Collins robertc at robertcollins.net
Thu Jul 24 01:14:42 BST 2008


On Thu, 2008-07-24 at 10:00 +1000, Ian Clatworthy wrote:
> I need to refactor the export code as part of the next
> round of content filtering enhancements. Right now, the
> various exporters (except the zip one) delegate to the
> InventoryEntry subclasses to do some of the work.
> IIRC, there was a 'reduce the complexity of InventoryEntry'
> drive some time back with a goal of one day eliminating it.
> 
> Any objections if I move the interesting code into the exporters
> and deprecate the matching methods in InventryEntry? I want
> to at least move the code, so the question is more one of
> "Should I deprecate while I'm at it?".

put_on_disk is likely best turned into a call to tree.iter_file_bytes.

as for get_tar_item, no opinion any which way; though it would be nice
to have that accessible from elsewhere after the move too.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080724/7f5924b6/attachment.pgp 


More information about the bazaar mailing list