[MERGE] Fast _walkdirs for win32

Adrian Wilkins adrian.wilkins at gmail.com
Thu Jul 17 13:55:10 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Ian Clatworthy wrote:

> | Please ping others (spiv and/or markh say) familiar with pyrex and
> | the win32 API used to review the code in bzrlib/_walkdirs_win32.pyx.
> | The rest is fine, assuming we only need to handle files and dirs at
> | this level. (I gather symlinks and tree references are handled higher
> | up the stack.)
> 
> Windows filesystems can't have symlinks, and tree references are indeed
> handled higher up the stack.
> 

Not strictly true ; NTFS 6 (Vista, 2k8) supports symlinks, although I'd hardly
call them a mainstream feature. I'm not sure how well they'd be supported by the
current Python libraries even if we made a special effort to use them.

NTFS 5 supports something called "junctions" which are link-ish but only work on
directories.

> |
> | bb: comment
> |
> | (This is actually a tweak vote assuming someone else reviews the pyx
> | file as mentioned. I'm making it 'comment' so BB doesn't take it off
> | the queue for other reviewers just yet.)
> |
> | Ian C.
> |
> 

I'm looking at the pyx, but I have never written any pyx myself, so my ability
to review it is pretty much limited to making sure there are no huge gaffes with
regard to the windows API. They'd have to be huge for me to spot them.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIf0DPcP1uebIhWSYRApxIAJ98LNDLoZhrQVn0S01rSwnbH1FbyQCfdbyF
rbsTdFuIrFF0B4vMaIdvplI=
=pNwC
-----END PGP SIGNATURE-----



More information about the bazaar mailing list