[MERGE] Handling frozen set inputs in mpdiff generation when a key is missing

Ian Clatworthy ian.clatworthy at canonical.com
Thu Jul 17 08:17:31 BST 2008

Robert Collins wrote:
> On Thu, 2008-07-17 at 14:37 +1000, Andrew Bennetts wrote:
>> John Arbash Meinel wrote:
>>> Robert Collins wrote:
>>> | Just some minor tweaks found during b+tree index development.
>>> |
>>> | One interns GraphIndex strings, the other handles error raising when the
>>> | input to mpdiff generation was a frozenset.

>>> I'm not 100% sure about interning the strings, but the other is
>>> certainly good.
>>> Have you tested the intern() with a large repository and what happens
>>> with memory consumption and speed?
> Yes, it was better :). I tested with a 334MB GraphIndex that would not
> parse at all with 2GB of ram, it made a modest improvement in memory
> use.

>> That said, it's a fairly subtle tweak purely for performance reasons, and so it
>> probably deserves a brief comment explaining why it's there.


Ian C.

More information about the bazaar mailing list