[MERGE] Handling frozen set inputs in mpdiff generation when a key is missing

[Robert Collins]

On Thu, 2008-07-17 at 14:37 +1000, Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Robert Collins wrote:
> > | Just some minor tweaks found during b+tree index development.
> > |
> > | One interns GraphIndex strings, the other handles error raising when the
> > | input to mpdiff generation was a frozenset.
> > |
> > | -Rob
> > |
> >
> > I'm not 100% sure about interning the strings, but the other is
> > certainly good.
> >
> > Have you tested the intern() with a large repository and what happens
> > with memory consumption and speed?

Yes, it was better :). I tested with a 334MB GraphIndex that would not
parse at all with 2GB of ram, it made a modest improvement in memory
use.

> The intern() call makes sense to me, but then I think I was the person that
> originally suggested it :)

Yup, you are :).

> That said, it's a fairly subtle tweak purely for performance reasons, and so it
> probably deserves a brief comment explaining why it's there.

Sure.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: updated.patch
Type: text/x-patch
Size: 5070 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080717/53fbe737/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080717/53fbe737/attachment-0001.pgp