[MERGE] Handling frozen set inputs in mpdiff generation when a key is missing
John Arbash Meinel
john at arbash-meinel.com
Wed Jul 16 19:17:34 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
| Just some minor tweaks found during b+tree index development.
|
| One interns GraphIndex strings, the other handles error raising when the
| input to mpdiff generation was a frozenset.
|
| -Rob
|
I'm not 100% sure about interning the strings, but the other is
certainly good.
Have you tested the intern() with a large repository and what happens
with memory consumption and speed?
I would also think that "interning" some of the tuples would be helpful.
Which made me think about passing in a caching dictionary into
'iter_entries' that has a lifetime of ~ 1 iter_entries call. (Or
possibly 1 graph search, etc.)
I would guess that a simple FIFO Cache would also work really well in
that situation.
Anyway
BB:approve
Though I would like to have more specifics about intern()
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkh+Oz4ACgkQJdeBCYSNAAMG8ACeKLiBGRNrWMVQxOrb+glVgo7e
vwQAn1T7E83YI7xeZqTYp7s6InVVonhM
=u3A4
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list