Accidental

[David Ingamells]

Martin Pool wrote:
> On Tue, Jul 15, 2008 at 5:45 AM, John Arbash Meinel
> <john at arbash-meinel.com> wrote:
>   
>> Well, I know 'pqm-submit' takes the extra step to check if you have
>> uncommitted changes, and by default aborts. It wouldn't be hard to have 'bzr
>> send' do a 'is working tree clean' check first. It *might* make it a little
>> slower, is the only real reason not to.
>>     
>
> I think it would be worthwhile to at least give a warning if there are
> uncommitted changes or if you're sending an empty merge request.  If
> people know what they're doing it should be unobtrusive; if they're
> new to it it will give them a clue as to what to do; and if like John
> and myself they know how it works but they occasionally forget to
> commit it may be helpful. :-)
>
>   
I've written a script that does the commit and send together, and what 
is more also checks if there are any unknown files in the working tree: 
"bzr add" is also something that people sometimes forget - I know I have 
and was caught by that script. The script prompt with a list of the 
unknown files (as reported by bzr status) and asks for permission to 
proceed. It costs very little extra time.