[MERGE] Add test for smart client invoking server-side hook on set_last_revision_info

John Arbash Meinel john at arbash-meinel.com
Mon Jul 14 03:05:28 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Andrew Bennetts wrote:
>> Hi,
>>
>> This patch just adds a test.  It tests that calling set_last_revision_info on a
> [...]
> 
> Attached this time.
> 
> -Andrew.
> 
> 

BB:tweak

I think it is genuinely necessary to do this, but I also think it needs to be
done at a higher level.

Namely, at WT.commit() and WT/Branch.push

That is what happened with set_rh(). We just stopped calling
'set_revision_history' when we switched to set_last_revision_info.

And theoretically, we only *need* to call 'set_last_revision()', so a future
branch format might only use that.

*I* am the one that broke set_rh, but that is partially because I didn't
realize I was breaking it, and partially because it needed to be switched. But
if we had a 'bzr commit fires set_last_revision hook', we would have at least
been aware and the opportunity to make a decision.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIerRoJdeBCYSNAAMRAq36AJ98ykbqByE7ITssj4zbeNF7HUPlMgCdGoW1
gmLBa/w5EifapwEGEBlbbZY=
=k7ZR
-----END PGP SIGNATURE-----



More information about the bazaar mailing list