[MERGE] Content filtering (EOL part 2 of 3)

Martin Pool mbp at canonical.com
Thu Jul 10 03:18:38 BST 2008


On Wed, Jul 9, 2008 at 9:49 PM, John Arbash Meinel
<john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin Pool wrote:
>> On Wed, Jul 9, 2008 at 11:49 AM, Ian Clatworthy
>> <ian.clatworthy at internode.on.net> wrote:
>>>> I think going to a callable is better because there may be some filters
>>>> that can be parameterized in arbitrary different ways not just by a small
>>>> set of values.
>>> You're probably right but I was treating this as YAGNI. I hope there's
>>> enough abstraction in the API for this to be supported via refactoring later.
>>
>> I can't help noticing that two paragraphs earlier you used an object
>> rather than a dict to  allow future evolution. :-)
>
> Speaking of which, if you are using an object-per-file you should at least be
> using __slots__ to make them a little more lightweight.

I don't think any of these apis imply an object per file.  It is very
desirable that we do not.  In fact it would be good to specifically
say so in the docstring.



More information about the bazaar mailing list