PQM silent branch lossage
Barry Warsaw
barry at canonical.com
Wed Jul 9 14:31:25 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Jul 9, 2008, at 9:22 AM, John Arbash Meinel wrote:
> Then again, you can't *quite* do this, because until you've
> processed some of
> the request, you don't have enough info to know who to send to.
> That, and I
> think by design he wanted invalid (by gpg, or whatever) to just get
> ignored,
> rather than having someone spam the PQM with invalid requests cause
> a DOS.
I think it would be fine to not send email on certain error conditions
that could be used as a vector for spam, such as invalid signatures.
OTOH, PQM should still clearly log exactly why such requests (merge or
otherwise) are getting dropped. It's been my experience that some
silent failures are really silent in that they aren't included in the
log output, or at least not in a way that you can ever match up the
request with the logged information.
- -Barry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
iEYEARECAAYFAkh0va4ACgkQ2YZpQepbvXFM/wCcDp5CTy6MO0PrSJxEEvzhG8X8
JocAoLTvA1UmZrcUy0b7ytSzJGSFanHs
=2Ik3
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list