[MERGE] Redo annotate more simply, using just the public interfaces for VersionedFiles.
Robert Collins
robertc at robertcollins.net
Tue Jul 8 05:43:56 BST 2008
On Mon, 2008-07-07 at 17:59 +1000, Martin Pool wrote:
> I added this additional patch to make test_annotate pass in the
> "named-nograph-knit-pack) case, where get_parents returns None as the
> parents of all requested revisions.
>
> This patch is not quite satisfactory because it seems like a bit of a
> hack when the code is not being clear about just what should be
> expected in these values. Feedback would be very welcome.
The None is returned when there is no graph actually stored. I feel its
cleaner not to invent parent lists that don't actually exist. As to this
specific fix - I don't know that we want to be doing bzrlib.graph
operations for a VersionedFile store that has no graph.
The test is just for completeness; we could equally say that a no-graph
versioned files should error on annotate().
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080708/5bbdd194/attachment.pgp
More information about the bazaar
mailing list