[MERGE] Redo annotate more simply, using just the public interfaces for VersionedFiles.

Martin Pool mbp at canonical.com
Fri Jul 4 05:52:57 BST 2008


On Fri, Jul 4, 2008 at 1:40 AM, John Arbash Meinel
<john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin Pool wrote:
> |> time bzr annotate --show-ids bzrlib/builtins.py > /dev/null is a pretty
> |> good one.
> |
> | I measured this and it is about 30x slower.  So I'll put up a patch
> | which makes the newer code conditional, and we probably need to do
> | something beyond this.
>
> That seems.... significant :)

I have to confess it was partly measurement error as I had not rebuilt
the extensions in the branch with the annotation patch.  But it's
still about a factor of 7x, and enough not to pay it unless we have
to.

I'm going to put in the conditional and send this to pqm.  Once the
rest of stacking is in we'll need to reevaluate performance in that
situation.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list