[MERGE] Implement PreviewTree.stored_kind, PreviewTree.is_executable

Aaron Bentley aaron at aaronbentley.com
Wed Jul 2 19:15:43 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Conditionally approved
> Comment:
> Again, it seems like you need to test the case where the file *isn't*
> different from the base.

No, the existing PreviewTree tests handle that case.

> Also, you only test stored_kind() for file
> objects, and is_executable() for when it is True. I would like to see at
> least 2 tests for each function, so the test can't pass by just writing
> "def stored_kind(self): return 'file'"

The existing tests ensure that you cannot implement it that way.  I am
testing that if you change the value, the changed value is detected.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIa8XP0F+nu1YWqI0RAs8cAJ4wm2R/MvDI2W0NsAZnhZPFuwAJLQCePrNO
7T6jGFsaDGknrxfj1fYeTes=
=+T8u
-----END PGP SIGNATURE-----



More information about the bazaar mailing list