[MERGE] Stacking policy

Ian Clatworthy ian.clatworthy at internode.on.net
Wed Jul 2 03:14:54 BST 2008


Aaron Bentley wrote:

> Thanks for your review.

bb:tweak

> +        :param url: The url create the clone at.  If url's last component does
> +            not exist, it will be created.

s/create/to create/

> +    old_parsed = urlparse.urlparse(old_base)
> +    new_parsed = urlparse.urlparse(new_base)
> +    if (old_parsed[:2]) != (new_parsed[:2]):
> +        raise errors.InvalidRebaseURLs(old_base, new_base)
> +    return determine_relative_path(new_parsed[2],
> +                                   osutils.pathjoin(old_parsed.path, url))

You updated new_parsed.path to new_parsed[2] but missed old_parsed.path
here.

Ian C.



More information about the bazaar mailing list