[MERGE] Add support for branch-associated locations

Aaron Bentley aaron at aaronbentley.com
Mon Jun 30 06:25:45 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Aaron Bentley wrote:
>> +    :parent, :submit, :public, :push, :this,and :bound are currently
> 
> You don't need the comma after :this. If you want to keep it, add a
> space after it.

Thanks.  I'll add a space.

>> +class DirectoryLookupFailure(BzrError):
>> +    """Base type for lookup errors."""
>> +
>> +    pass
> 
> I'm pretty sure that the docstring is enough as the class body, i.e.
> you don't need pass here.

It is.  Of course, I wrote the docstring afterward...

> OTOH, pass does make it explicit that you
> meant the class to be empty so I'm fine with leaving it there if
> you prefer.

I think that's reasonable.  Thanks for your review.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIaG5Z0F+nu1YWqI0RAndyAJ9g2Q/VKIae4tup6DtKVSILQabBQQCggc/9
lcMdE1AON/U6Wgk1Lsq56z8=
=/KiO
-----END PGP SIGNATURE-----



More information about the bazaar mailing list