[MERGE] Implement generic stacking rather than pack-internals based stacking.

[Robert Collins]

On Wed, 2008-06-25 at 09:03 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1


> - -
> - -        total_revisions = self._local_revision_index().key_count()
> - -        total_packs = len(list(collection for collection, sizes in
> - -            self._names.values() if collection is self))
> +        total_revisions = self.revision_index.combined_index.key_count()
> +        total_packs = len(self._names)
> 
> 
> ^- This seems to be counting all revisions in all packs, but only using
> the names from the local packs. Seems a little odd.

There are only local packs.

> Also, in general having the api be:
> 
> ~ self.revision_index.combined_index
> 
> Is a bit strange. What is self.revision_index if it isn't the combined
> index? I suppose if this is all just a plain "revert" to rip out all the
> places that you were stacking in the internal structures, then there
> isn't much for you to really do about it.

it is always the combined index :).

> So overall
> 
> BB:approve
> 
> (Though this was only reviewing the "internals-to-generic.patch".

Cool - thanks!

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080626/47d523a6/attachment.pgp