[MERGE] Redo annotate more simply, using just the public interfaces for VersionedFiles.
John Arbash Meinel
john at arbash-meinel.com
Wed Jun 25 15:21:53 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
| This builds on the stackings knits patch to allow annotate to work.
|
| It's a lot simpler than the previous code [John suggested this
| approach :P].
|
| It likely has higher memory use, but shouldn't AFAICT be slower, because
| this will issue a single get_record_stream call (and that should be
| doing optimisations anyway).
|
| -Rob
|
It will be slower primarily because we can't use the cached matching
blocks. So we have to re-diff every file.
I don't know about the specific memory use, but a lot of the complexity
was allowing the records to come back in non-topological (pack optimal?)
order, and deferring entries that still needed parents.
Oh, and not caching all of the texts. That is actually a rather big
memory issue. It tracked when texts would no longer be needed. But as I
said on IRC, there is a difference from working at all, and from being
fast if it only actually worked.
Though I was thinking you would do it based on whether we were stacked
or not, as this pretty much nukes all of Pack based annotation,
regardless of whether you are stacking on another repository.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhiVIEACgkQJdeBCYSNAAOXVgCZAfROpm4nBktSF5+Yv5DO05mB
mK0AoJNXm7iZQsY0Y7du8ZBvvOWRYAhf
=myns
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list