[MERGE] Stacking policy
aaron at aaronbentley.com
Mon Jun 23 15:46:27 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Ian Clatworthy wrote:
> Aaron Bentley wrote:
>> Ian Clatworthy wrote:
>>> Aaron Bentley wrote:
>>>> This patch implements policy for stacking branches.
> Well done on this. A bit more feedback below for your consideration.
Thanks for your review.
>>>> +class TestTransportConfig(TestCaseWithBzrDir):
>>>> + def setUp(self):
>>>> + TestCaseWithBzrDir.setUp(self)
> I included this method in my previous email but I forgot to mention why.
> As all it does in call the matching method in the superclass, it's
> redundant isn't it?
> This particular change looks all good to me. Immediately after this, the
> (old) code goes on to open the branch and set local_branch again. As you've
> already done that now, I think the try/catch/else I'm talking about can
> simply become something like:
You're right. Thanks.
> if local_branch is not None:
>> @@ -973,6 +1024,7 @@
>> cloning_format = self.cloning_metadir()
>> result = cloning_format.initialize_on_transport(target_transport)
>> + repository_policy = None
> It doesn't do any harm but I think that setting repository_policy to None is
> not needed here? It looks like all code paths go through the bit that set
> it later on.
Fixed. I can only assume that it made sense at one stage.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 125109 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080623/81147193/attachment-0001.bin
More information about the bazaar