[MERGE] Add Remote-v2 variant to branch/repository/bzrdir implementations tests.

[Ian Clatworthy]

Ian Clatworthy wrote:
> Andrew Bennetts wrote:
>> This patch adds another scenario to the parameterised tests that already take
>> Remote* objects to test HPSS protocol v2 (and <= 1.2 HPSS verbs).  This
>> exercises both the v2 client and server code, and also any fallback logic in the
>> Remote* client objects for coping with 1.2 servers (and thus exercising verbs
>> that might only get used by those clients).
> 
> bb: approve

Let me change that vote to 'tweak' as the changes break the test suite. Some
minor tweaks ought to be enough to fix these ...

ERROR: test_formats_to_scenarios (bzrlib.tests.test_selftest.TestRepositoryParameterisation)

vvvv[log from bzrlib.tests.test_selftest.TestRepositoryParameterisation.test_formats_to_scenarios]

^^^^[log from bzrlib.tests.test_selftest.TestRepositoryParameterisation.test_formats_to_scenarios]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ian/bzr/repo.packs/bzr.tmp/bzrlib/tests/test_selftest.py", line 268, in test_formats_to_scenarios
    None)
  File "/home/ian/bzr/repo.packs/bzr.tmp/bzrlib/tests/repository_implementations/__init__.py", line 61, in formats_to_scenarios
    for scenario_name_suffix, repository_format, bzrdir_format in formats:
ValueError: need more than 2 values to unpack

======================================================================
ERROR: test_setting_vfs_transport (bzrlib.tests.test_selftest.TestRepositoryParameterisation)

vvvv[log from bzrlib.tests.test_selftest.TestRepositoryParameterisation.test_setting_vfs_transport]

^^^^[log from bzrlib.tests.test_selftest.TestRepositoryParameterisation.test_setting_vfs_transport]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ian/bzr/repo.packs/bzr.tmp/bzrlib/tests/test_selftest.py", line 247, in test_setting_vfs_transport
    vfs_transport_factory="vfs")
  File "/home/ian/bzr/repo.packs/bzr.tmp/bzrlib/tests/repository_implementations/__init__.py", line 61, in formats_to_scenarios
    for scenario_name_suffix, repository_format, bzrdir_format in formats:
ValueError: need more than 2 values to unpack

Ian C.