[MERGE] (fixes #240910) Serve all filesystem roots on Windows

John Arbash Meinel john at arbash-meinel.com
Thu Jun 19 00:00:36 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adrian Wilkins wrote:
| Add a couple of special cases to urlutils._win32_path_(from|to)_url
|
| This fixes the bug by allowing a LocalTransport with an empty string for
| a base path to be created (only on Windows).
|
| These now behave as you might expect on Windows.
|
| bzr ls bzr://camelot/d:/branch  # where ``bzr serve --directory=/``
| bzr ls bzr+ssh://robin@camelot/d:/repo/branch
|
| Previously you were restricted to paths relative to the root of the
| drive that Python.exe is on.
|
| e.g.
| bzr ls bzr+ssh://robin@camelot/repo/branch # only works if repo is on c:
|
| It doesn't seem that you can access UNC paths over the server (but then
| you couldn't do that anyway before the bug was fixed). If that's a
| problem, you always have the workaround of mapping a drive letter, or
| fixing it a bit more...
|

I'm pretty sure that "file://" is not really a valid URL, and it should
be "file:///". (I believe that file:// is just a scheme).

Also it seems like this fails the "round trip" test. Specifically:

from_url(to_url('/')) == ''
to_url(from_url('file://')) ??? (Your check uses '/' to indicate it
should be 'file://').

I would really like to merge something like this, but I don't think this
is quite right.

BB:resubmit

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhZk5QACgkQJdeBCYSNAANINACeK8SvRTCDZG8OlXXqudQRt8l0
Q00Ani2KaLjxn/nf43sbxZ+fW+n9B7rI
=BFXi
-----END PGP SIGNATURE-----



More information about the bazaar mailing list