Push location hiding

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Everything thinks it is okay. However the push location is saved to
> .bzr/branch/branch.conf. And 'locations.conf' overrides branch.conf,
> even though one is achieved recursively, and the other is explicitly for
> that branch.

The rationale for making locations.conf trump branch.conf was because
locations.conf is unambiguously under the user's control and can be
changed without affecting others.

The rationale for making recursive locations.conf rules trump
branch.conf values was avoiding extra complexity in the user model.

> I don't have any way to force the remember, other than manually hacking
> locations.conf for that branch.
> 
> Is there something better that we could be doing?

We could set it in BOTH branch.conf and locations.conf, I suppose...

> Some way that we could
> get --remember to actually --remember? (Certainly we should probably at
> least be warning if we don't)

We are doing set_user_option(.., warn_masked=True).  That ought to
produce a warning.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIWTEb0F+nu1YWqI0RAt5AAJ9Qqex4xZfznr+ofdEK16Ebew0zVQCfctXA
VuVRuRYV/kR3ng/T5YCyJ/g=
=spiN
-----END PGP SIGNATURE-----