[MERGE] Update to bzr.dev.
Andrew Bennetts
andrew at canonical.com
Thu Jun 12 06:57:02 BST 2008
Robert Collins wrote:
[...]
> Uhm. Yeah.
>
> NEW and IMPROVED (updated to bzr.dev).
>
> KTHANKSREVIEW (I'm sorry, really I am)
:)
Some quick review comments just on the parts that directly touch HPSS code (I'm
guessing you won't mind receiving review comments incrementally given the size
of the patch!):
> === modified file 'bzrlib/remote.py'
[...]
> - @needs_read_lock
> - def get_inventory_weave(self):
> + @property
> + def inventories(self):
> self._ensure_real()
> - return self._real_repository.get_inventory_weave()
> + return self._real_repository.inventories
[...]
> + @property
> + def inventories(self):
> + """Decorate the real repository for now.
> +
> + In the long term a full blown network facility is needed to
> + avoid creating a real repository object locally.
> + """
> + self._ensure_real()
> + return self._real_repository.inventories
> +
You only need to define this once :)
> + @property
> + def revisions(self):
[...]
> + @property
> + def signatures(self):
[...]
> + @property
> + def texts(self):
These ones look good. I particularly appreciate clear docstrings.
> === modified file 'bzrlib/smart/repository.py'
> --- bzrlib/smart/repository.py 2008-05-08 04:33:38 +0000
> +++ bzrlib/smart/repository.py 2008-06-12 01:59:43 +0000
> @@ -257,7 +257,6 @@
> firstrev: 1234.230 0
> latestrev: 345.700 3600
> revisions: 2
> - size:45
I'm slightly surprised that this part of the gather_stats RPC response is
removed by this patch. It appears that old clients will cope just fine with the
absence of this line though, so that's good.
-Andrew.
More information about the bazaar
mailing list