[BUG] bzrlib.tests.branch_implementations don't actually test RemoteBranch

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I don't know exactly why, but I did just find out that the
branch_implementations tests aren't actually testing RemoteBranch. Specifically,
I did this:

def test_XXX(self):
~  print self.branch_format
~  tree = self.make_branch_and_tree('.')
~  print tree.branch

And for:
~  <bzrlib.remote.RemoteBranchFormat object at 0x02AC64D0>
it gives
~  BzrBranch6('URL...')

I think Andrew Bennetts noticed this a day or two ago, but it seems to be a
rather serious flaw in our testing logic.

Specifically, I wanted to write a test to exercise that Branch.pull() returns a
PullResult object, to close bug #238149. When I wrote a test that should fail, I
was surprised to see all tests passing, (even though it listed RemoteBranch as
one of the tested formats.)

When I put a trace statement into the RemoteBranch.pull() function, it was never
executed.

I went ahead and opened a bug about this:
~  https://bugs.edge.launchpad.net/bzr/+bug/238227

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhLCF0ACgkQJdeBCYSNAAPgMwCfXfw3SnhwPT5mpL0Q+LjD+8TK
F94AniQtnizLYQNJUGgRqpz4aKZ+cqT4
=vZ8J
-----END PGP SIGNATURE-----