[MERGE] Move UnicodeFeature into a core 'tests' feature, rather than living in test_diff.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
|>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:
|
|     john> I've often wanted to do this. UnicodeFeature is generally useful,
and should be
|     john> used in more tests. This patch just changes it to be more available.
|
|     john> John
|     john> =:->
|
|     john> # Bazaar merge directive format 2 (Bazaar 0.90)
|     john> # revision_id: john at arbash-meinel.com-20080605210642-zoc3nelx84xmsxuf
|     john> # target_branch: http://bazaar-vcs.org/bzr/bzr.dev
|     john> # testament_sha1: ed7ed6afef0c10ff6d1ebe33ff91b9af791abddd
|     john> # timestamp: 2008-06-05 16:06:48 -0500
|     john> # source_branch: http://bzr.arbash-meinel.com/branches/bzr/1.6-\
|     john> #   dev/symlink_unicode_135320
|     john> # base_revision_id: pqm at pqm.ubuntu.com-20080605191237-2306x0goo9pfh9to
|     john> #
|     john> # Begin patch
|     john> === modified file 'bzrlib/tests/__init__.py'
|     john> --- bzrlib/tests/__init__.py	2008-06-04 05:59:16 +0000
|     john> +++ bzrlib/tests/__init__.py	2008-06-05 21:06:42 +0000
|     john> @@ -3062,6 +3062,26 @@
|     john>  OsFifoFeature = _OsFifoFeature()
|
|
|     john> +class _UnicodeFilename(Feature):
|
| Since you said "UnicodeFeature is generally useful", why not call
| it such ? Or UnicodeFilenameFeature ?
|
| bb:tweak
|
|         Vincent
|

Just a typo on my part. UnicodeFilename is a feature.
Interestingly, all of the other features are labeled as such:
bzrlib/tests/test_diff.py:44:class _CompiledPatienceDiffFeature(Feature):
bzrlib/tests/test_diff.py:59:class _UnicodeFilename(Feature):
bzrlib/tests/test_knit.py:73:class _CompiledKnitFeature(Feature):
bzrlib/tests/test_win32utils.py:28:class _NeedsGlobExpansionFeature(Feature):
bzrlib/tests/test_win32utils.py:39:class _Win32RegistryFeature(Feature):
bzrlib/tests/__init__.py:3028:class _SymlinkFeature(Feature):
bzrlib/tests/__init__.py:3039:class _HardlinkFeature(Feature):
bzrlib/tests/__init__.py:3050:class _OsFifoFeature(Feature):
bzrlib/tests/__init__.py:3123:class _FTPServerFeature(Feature):
bzrlib/tests/__init__.py:3143:class _CaseInsensitiveFilesystemFeature(Feature):

So I'll fix this UnicodeFilename => UnicodeFilenameFeature and submit.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhJN8oACgkQJdeBCYSNAAPi1gCdFHk+lQXlqEX6Lzlpc2PN+nVO
48EAoKkkDc8ccwD0pd9Hpnx2zAJFPluc
=0p3h
-----END PGP SIGNATURE-----