[MERGE] repository external reference tests (StackedBranches)
Robert Collins
robertc at robertcollins.net
Thu Jun 5 08:23:53 BST 2008
On Thu, 2008-06-05 at 09:02 +0200, Vincent Ladeuil wrote:
>
> You are implementing a specialized adapter inline. I'd prefer a
> true class, that will allow further subclassing and make the
> load_tests() function easier to read and to extend.
>
> Have a look at tests/test_http.py for a more complex example
> illustrating my points.
Actually I spent a lot of time splitting out the responsibility of
adapting (now a simple class in tests) and defining scenarios - what
this does here.
Conflating them makes them harder to mix and match which is why I
*stopped* that.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080605/af5af766/attachment.pgp
More information about the bazaar
mailing list