timestamps and export

James Westby jw+debian at jameswestby.net
Tue Jun 3 13:04:47 BST 2008

On Tue, 2008-06-03 at 10:53 +1000, Martin Pool wrote:
> I think it should; presumably that gets either the revision value or
> the last-changed-revision value.

A quick glance at the code suggests that RevisionTree uses the
timestamp of the associated Revision object, so all files would
have the same timestamp.

> For exporting the working tree I think either the on disk mtime or the
> current time would be reasonable.

WorkingTree and DirstateRevisionTree differ here, the former returns
the disk mtime, the latter the timestamp of the revision that last
changed the file.

This means that of these 3 implementations (the other is in transform.py
and thunks through to the tree's implementation in at least some cases)
there are 3 different semantics for the value returned.

It seems odd to have two different things returned for the two working
tree methods, and two different things for the ones that use the
revision timestamp, is that the way we want it?



More information about the bazaar mailing list