[MERGE][bug #172649] 'bzr uncommit' avoids 'branch.revision_history()'

Ian Clatworthy ian.clatworthy at canonical.com
Thu May 29 03:28:27 BST 2008


John Arbash Meinel wrote:
> This patch updates 'bzr uncommit' to avoid ever accessing
> 'Branch.revision_history()'. This saves a lot of time, and makes the
> command
> much more interactive.

This is looking promising but isn't ready for merging yet.
In particular, 'bzr selftest uncommit' has 9 failures and
'bzr selftest log' isn't pretty. :-)

bb: resubmit

Another minor thing ...

> -            if verbose:
> -                print 'Removing revno %d: %s' % (len(rh)+1, rev_id)

We can't take that logic out without violating what the docstring
promises. I can't see that verbose gains anything here myself so
I'd be ok with updating the docstring to say that the parameter is
ignored. While you're there, could you add a param description for
local please?

Ian C.



More information about the bazaar mailing list