[MERGE] add lock hooks

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| Here is an updated version of this patch.  Compared to the previous one.
|
| * New base class PhysicalLock, with a .hooks attribute, rather than having
|   it in the module namespace (where it might easily be incorrectly
|   imported.)
|
| * Hooks base class gains clone() and clear_hooks() methods, which I think
|   are a cleaner way to save/clear/restore the hooks in tests or similar.
|
| * It's updated for changes in the hooks api since it was written.
|
| * Hooks renamed to lock_acquired and lock_released in keeping with the
| general style of naming.


+class LockResult(object):

^- Ian made a strong argument for calling these "Params" rather than "Results".
I could go either way here. You *are* talking about the result of locking, but
it is the parameters being passed to the hooks.


You mention PhysicalLock.hooks in your email and in NEWS, but I see:

~ class LockDir(object):
- -    """Write-lock guarding access to data."""
+    """Write-lock guarding access to data.
+
+    :cvar hooks: Hook dictionary for operations on locks.
+    """

~     __INFO_NAME = '/info'

+    hooks = Hooks()


^- No inheriting from PhysicalLock, just LockDir.hooks

So I'm thinking you forgot to commit something. Otherwise this would probably be
approve.

BB:resubmit

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkg8Ek8ACgkQJdeBCYSNAAMfrwCgl+OZkrVraQ8fC21VokycUkpJ
GU0Ani1TQ/g2H4lRhDBkvRllShmLWNJX
=N1zz
-----END PGP SIGNATURE-----