[PATCH] [Bug 209281] Re: Windows diff apps don't understand symlinks created by Cygwin bzr diff --using

[Matt McClure]

Ian,

On Thu, May 22, 2008 at 2:47 AM, Ian Clatworthy <
ian.clatworthy at canonical.com> wrote:

> IMO, this is almost ready to merge. It still needs a test and
> two tweaks:
>
> 1. osutils.host_os_dereferences_symlinks() is a public function so
>   it needs a test added to tests/test_osutils.py. I'm ok if the
>   test simply checks that the function is present, i.e. it can be
>   called without throwing an exception.
>
> 2. In test_diff.py, result=proc.stdout.read() needs spaces either
>   side of the = character.
>
> 3. It's fixing a bug so please add an entry into NEWS.
>
> As a final comment, sending diffs to the list is OK but sending
> merge directives is better. Here's one way to do that:
>
>  bzr send -o ../59302.x.patch
>  (switch to your mail tool and attach the file)


See the attached merge directive.  I believe it addresses the items above.

Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20080526/0f8af1b7/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug.209281.8.patch
Type: application/octet-stream
Size: 23037 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080526/0f8af1b7/attachment-0001.obj