[merge] errors in deleting obsolete packs should not be fatal (was Re: Problems with NFS mounted filestore)

[Russel Winder]

Martin,

On Mon, 2008-05-26 at 13:40 +1000, Martin Pool wrote:
> On Sun, May 25, 2008 at 6:57 PM, Russel Winder
>
> > However, the branch consistently fails to work when run on a machine
> > which mounts the filestore over NFS.  I have just undertaken the branch
> > on the fileserver itself and that is fine.  I don't know if this is a
> > bzr or bzr-svn thing, nor whether it is a known issue, i.e. should I
> > report a bug?
> 
> Thanks for the report.  This is a new bug.

OK.  Is this something relatively new, 1.5-ish -- I am fairly sure I
have not had this problem before 

> Could you please try merging this patch?

Currently I am using the latest released distributions of things --
bleeding edge but not entirely amenable to simple patching.  If someone
could induct me into the correct and proper way of working with a live
development branch, I am certainly willing to give it a go.

I am assuming that keeping a mirror of the current development master,
then branching it and applying the patch will be involved (is a shared
repository best for this sort of thing?).  The question is how to use
Bazaar direct from the branch rather than installing it.

> The .nfs* files are NFS internal housekeeping for files that have been
> deleted by one client but that are still in use by another.  More
> generally, if we fail to delete one of these leftover files it
> shouldn't be considered a fatal error.  I think if the client(?)
> abruptly disconnects they can be left behind for a long time.

I would guess that bzr is actually multi-threading and that one thread
is deleting the file before another thread has released it.  Certainly
the only way that the .nfs files get created is when the file is opened
by a process when another process deletes it.  However bzr is the only
process at work in that directory at that time so it must be an internal
bzr thing.

> Arguably we should just specifically ignore all .nfs* files.

But it might be worth considering why bzr is creating these things in
the first place.  It indicates there might be resource claim/release
problems that have arisen in either 1.4 or 1.5.

RAII is your friend :-)

-- 
Russel.
====================================================
Dr Russel Winder                 Partner

Concertant LLP                   t: +44 20 7585 2200, +44 20 7193 9203
41 Buckmaster Road,              f: +44 8700 516 084
London SW11 1EN, UK.             m: +44 7770 465 077
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080526/4598bb90/attachment.pgp