[MERGE] 1.5? Suppress DeprecationWarning in official releases

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| Martin Pool has voted tweak.
| Status is now: Conditionally approved
| Comment:
| I think this should be in NEWS.
|
| I think this is a reasonable tradeoff.  I do sometimes run Bazaar with
| -Werror and it would be nice if this did not override the -W flag when
| that is specified, especially for selftest.  But I'm OK to go back and
| fix that later, if it turns out that it is broken.  Perhaps eventually
| the test suite should hook into warnings and specially report them.

Actually, this breaks our python -Werror for the test suite... Thanks for
bringing that up.

We *want* DeprecationWarnings to cause the test suite to fail when run on PQM.
Should I change it so that selftest always makes DeprecationWarnings => "error".
That might be annoying if you just have a plugin installed.

My original idea was that people running 'selftest' with a release installation
wouldn't want 'ignore', and AFAICT there isn't a good way to just remove a
filter (without resetting the whole thing).

So I'll take out the line in 'cmd_selftest', as at least it lets PQM fail if
DeprecationWarnings are emitted.

I could also inspect 'warnings.filters' but I'm not a big fan of that.

|
| I did also wonder if we should treat bzrlib warnings differently from
| those from other libraries but I don't suppose the user would want to
| see them either.
|

I think for a release version we don't want either.

John
=:->

| For details, see:
|
http://bundlebuggy.aaronbentley.com/request/%3C482C5FAE.8040407%40arbash-meinel.com%3E

|
|
|

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgtpx0ACgkQJdeBCYSNAANvgwCgzq0LswbbcFzVgU6IkQZJQUW2
zLUAnjaJGPutmo10EySTQeQYPtr8KA9q
=Do/4
-----END PGP SIGNATURE-----