DeprecationWarnings

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Russel Winder wrote:
| Using my shiny new bzr 1.5~rc1, bzrtools 1.4.0, bzr-svn 0.4.10, I am
| seeing the following for every command:
|
| /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus/hook.py:30:
| DeprecationWarning: bzrlib.branch.BranchHooks.install_hook was
| deprecated in version 1.5.
|   Branch.hooks.install_hook('set_rh', on_set_rh)
| /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus/hook.py:35:
| DeprecationWarning: bzrlib.smart.server.SmartServerHooks.install_hook
| was deprecated in version 1.5.
|   SmartTCPServer.hooks.install_hook('server_started', on_server_start)
| /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus/hook.py:36:
| DeprecationWarning: bzrlib.smart.server.SmartServerHooks.install_hook
| was deprecated in version 1.5.
|   SmartTCPServer.hooks.install_hook('server_stopped', on_server_stop)
| /usr/lib/python2.5/site-packages/bzrlib/plugins/email/__init__.py:57:
| DeprecationWarning: bzrlib.branch.BranchHooks.install_hook was
| deprecated in version 1.5.
|   Branch.hooks.install_hook('post_commit', branch_commit_hook)
|
| Clearly deprecation warnings are actually important for developers but
| users really couldn't care less.  Well actually they do care, they just
| do not want to see these sorts of things!  I can cope with this, but I
| thought it worth raising so that final release software doesn't do this
| sort of thing.
|

I know that the trunk of the email plugin already has the right fix for this. I
believe dbus does as well, but I'm not positive on that one.

So it is just an issue of also creating new packages for those.

We *can* suppress the deprecation warning, and I'll write a quick patch for it
so we can review it. However, part of this is to get plugin authors, etc to
update their plugins.

ATM I think the "correct" fix is to have the main function check to see if this
is a "final" release, and if it is, don't issue deprecation warnings. For "dev"
or "candidate" it should continue to warn so people know about it.

The code is small, so I'll do it quickly.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgsWuQACgkQJdeBCYSNAAPspACguVk7Cf+qDJ8IrXzR601dRxFR
Q+sAoNjlQtPh2Gxt7MhIWYaCRaR1sBVg
=VosV
-----END PGP SIGNATURE-----