[MERGE] Fix #217650 by catching declarations outside sections.

Vincent Ladeuil v.ladeuil+lp at free.fr
Fri May 9 16:28:02 BST 2008


>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:

    john> Vincent Ladeuil wrote:
    >> Trivial patch attached.
    >> 
    >> Vincent
    >> 
    >> 

    john> Do we want to raise ValueError, or just warn and ignore
    john> that section?

I felt that ignoring the keyword = value was inappropriate here
because this can only be either a user error or some sort of
attack, so I prefer to error out.

Since other close cases were raising ValueError, I went for
consistency.

    john> Otherwise

    john> BB:approve

Ok.
        Vincent




More information about the bazaar mailing list