[MERGE] [Bug 226769] Disable some strace tests

[Robert Collins]

On Mon, 2008-05-05 at 15:13 +0200, Vincent Ladeuil wrote:
> >>>>> "martin" == Martin Pool <mbp at sourcefrog.net> writes:
> 
> <snip/>
> 
>     martin> I don't think we even have any current code that
>     martin> makes use of the strace function.  Perhaps the most
>     martin> practical thing is just to disable or delete it?  If
>     martin> we do want to retain it for use in testing/profiling,
>     martin> I think it would be reasonable to leave it in but
>     martin> untested, and allow people to fix it if it is broken
>     martin> when they need it.
> 
> Here is patch that skip the tests with a comment explaining why.

I make use of the strace function quite regularly. I don't want to have
to fix it if it bitrots.

I'd much prefer that the test remain enabled, and cause a failure rather
than a hang. This can be done by asserting that the active thread count
is 1.

Better yet, *every* test should:
 - record the active thread count when it starts
 - fail() if the active thread count when it finishes is different.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080506/ba16f7c6/attachment.pgp