[MERGE] [Bug 215426] Re: MemoryError - recv for HTTPthroughProxy

[Eric Holmberg]

Okay, let's see if this gets all of the issues captured and corrected.
If you guys see anything on here that I missed, please let me know as it
wasn't intentional.

Local TCP/IP Stack Usage Changed to Mock Object
-----------------------------------------------
I've changed the unit tests from a system-type test which used the
TCP/IP to a unit test using the mock object ReadFile.  ReadSocket was
suggested, but bzrlib.transport.http.response.RangeFile actually expects
a file interface, so I created a new ReadFile mock object in the
bzrlib.tests.test_http_response module.

This should address:
 1. Concerns about using the TCP/IP stack directly
 2. Available port selection
 3. Port-busy problems


Sorry about the initial confusion about the location of ReadSocket -- I
was looking in the Python modules instead of the
bzrlib.tests.test_http_response module.

Commented-out Unit Tests
------------------------
These have been removed as part of the unit-test rewrite for using mock
objects.


White-space, PEP8 Compliance
----------------------------
I've cleaned up any trailing white-space and bzr cdiff --check-style is
now clean.  I've tried to follow PEP8 as closely as possible, but I'm
sure I've missed something.  Recommendations for any other automated
tools that you would like me to run are appreciated, since style issues
are always an annoyance to deal with.


Other Issues
----------------------------
Other issues including comment changes for an explanation of the error
and documenting -1 for EOF have been added.


Regards,

Eric Holmberg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug215426-fix-v3.patch
Type: application/octet-stream
Size: 19475 bytes
Desc: bug215426-fix-v3.patch
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080501/37f531f2/attachment-0001.obj