[MERGE] Speed up diff spec handling.

Aaron Bentley aaron at aaronbentley.com
Thu Apr 24 23:23:39 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

This patch speeds up diff's handling of revision specs by using the new
as_revision_id method.

Unfortunately, I discovered (due to test failures) that the
_as_revision_id implementation of the branch: spec was broken-- it
doesn't do a fetch, to ensure that the revision is present in the local
branch.  But it also doesn't provide a different branch location, to
retrieve the spec from.  Which means that it can provide a revision_id
that the caller cannot use.

So I changed it do use fetch, as the current implementation does.  I
agree that using fetch should no longer be necessary, but that can be
fixed as a separate thing.

There are no tests, since this is an optimization, not a behavior change.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIEQhr0F+nu1YWqI0RAs6AAJ47IvqwbXbifhGNs3gNDD69o+4qJQCaArV2
xztfraohBfufuTVno/JzdZ8=
=PuL7
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Aaron's mergeable stuff-1926.patch
Type: text/x-diff
Size: 4448 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080424/5f5e5a86/attachment-0002.bin 


More information about the bazaar mailing list