[MERGE][BUG #214894] Repo.get_parent_map() correctness with mismatched servers

John Arbash Meinel john at arbash-meinel.com
Tue Apr 29 21:11:27 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch fixes some compatibility issues.

I don't have a test for it, because of the required configuration necessary to
provoke this bug.

Specifically, the bug is in the RemoteRepository compatibility code, when the
remote server is <v1.2. It switched to an alternate api which didn't actually
match 100% the current api. Which, I must say, took a lot of effort to figure
out what was going on.

I was fortunate enough to be given direct access to the users machine, so that I
could run "BZR_PDB=1" and get a debugger when the error occurred. (Because all
of my other checks showed that the repositories had the same revisions, etc.)

Anyway, as I mentioned, we may want to back-port this to a 1.3.2, or at least
something that we can get into Hardy. It isn't critical, because there are many
different ways to avoid it. (Upgrade your branches, match your client and server
versions, etc.)

Certainly I'd like to see this make it to our next release, at a minumum.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgXgO8ACgkQJdeBCYSNAAMAtwCeKiGsg00fLV9lqiKBQHfnm4pJ
b+MAn04O+H2ilfYdXk1xkxxlcjil6oq5
=7+/I
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: remote_get_parent_map_214894
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20080429/4531c912/attachment-0001.diff 


More information about the bazaar mailing list