[MERGE] Return (and expect) '3' rather than '2' from the 'hello' verb (protocol v3 patch 4/7)

[John Arbash Meinel]

John Arbash Meinel has voted tweak.
Status is now: Conditionally approved
Comment:
+    def args_received(self, args):
+        cmd = args[0]
+        args = args[1:]
+        try:
+            command = self._commands.get(cmd)
+        except LookupError:
+            raise errors.SmartProtocolError("bad request %r" % (cmd,))
+        self._command = command(self._backing_transport)
+        self._run_handler_code(self._command.execute, args, {})
+

^- Shouldn't this also raise UnknownSmartMethod?

So... won't older clients refuse to connect to a server which returns 
'3' for OK? It seems like all the logic in the server is still present 
to be able to talk in V2 mode. Shouldn't there be a way for clients to 
request this?


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20080423230050.GH9546%40steerpike.home.puzzling.org%3E